search

mnannola / ember-cli-aframe

Ember Addon for the A-Frame WebVR framework
https://mnannola.github.io/ember-cli-aframe/
MIT License
3 stars 1 forks source link

component clobbers previous tag #2

Open lukegalea opened 8 years ago

lukegalea commented 8 years ago

So, this is super weird and certainly not the "fault" of ember-cli-aframe, but maybe you know the source of this issue:

Your components all work perfectly, but when I make my own component with no tagName and include an a-frame component inside it, the tag immediately preceeding the component is just silently omitted from the DOM!

You can see it here in this repo: https://github.com/lukegalea/ember-vr/blob/master/app/templates/application.hbs#L6

The a-cylinder directly preceding it is not rendered.

If I put a dummy a-entity before it, then that gets clobbered instead.

But, your {{ember-a-box}} component is fine.

Any thoughts? Thanks in advance! I think the repo I have at https://github.com/lukegalea/ember-vr is about as simple a reproduction case as I can come up with.

lukegalea commented 8 years ago

actually, scratch that. It looks like in Ember 2.8 the {{ember-a-xxx} components also clobber the previous element.

Seems like it's related to some weird interaction with a-frame. I've been getting around it by putting
in like this:

<a-sphere></a-sphere

<br>
{{ember-a-box}}

Weird though..

mnannola commented 8 years ago

Hey Luke,

I saw this with the lighting components before, but not with any geometry components. I will check it out. Maybe something is happening where those components aren't registered with the AFRAME object when Ember tries to insert them into the DOM?

On Wed, Sep 28, 2016 at 1:07 PM, Luke Galea notifications@github.com wrote:

actually, scratch that. It looks like in Ember 2.8 the {{ember-a-xxx} components also clobber the previous element.

Seems like it's related to some weird interaction with a-frame. I've been getting around it by putting in like this:


{{ember-a-box position="-1 0.5 1" rotation="0 45 0" width="1" height="1"
depth="1" color="#4CC3D9"}}```

Weird though..

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/mnannola/ember-cli-aframe/issues/2#issuecomment-250250089>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACP95YhGFKLarYNdVTSCwHMmmdzd3-laks5quqz8gaJpZM4KIFLo>
.

Michael Nannola 512-751-8283