search

mnapoli / externals

Opening PHP's #internals to the outside
https://externals.io
MIT License
230 stars 25 forks source link

empty message #50

Open staabm opened 7 years ago

staabm commented 7 years ago

message is rendered empty, even if the plain source contains content https://externals.io/message/100697#100703 image

raw message https://externals.io/email/100703/source

mnapoli commented 7 years ago

Thanks, this has to do with the markdown rendering:

> This commit should fix the problem https://github.com/php/php-src/commit/
> 5ef10d08ec2d0823fb21ad189dacfb43d900a0b5
>
>
> Yes! I tested 7.2.0RC2 with this patch applied and it fixes the problem.
Thank you!

Since there is no empty line it is considered as a quotation.

Not sure what to do/if there is anything to do here.

gharlan commented 5 years ago

But why is the message empty? Shouldn't the quote be shown anyway?

mnapoli commented 5 years ago

This is because we hide quotes at the end of messages:

https://github.com/mnapoli/externals/blob/e22aa15db60840665bc67e0f9311d0e198ae40bc/res/assets/style.less#L329-L341

AllenJB commented 4 years ago

Appears to be another case of the same issue: https://externals.io/message/108175#108176