mnarizzano / SEEGA

SEEG Assistant
GNU General Public License v3.0
26 stars 17 forks source link

SEEGA failed in Slicer 4.11 #32

Closed windsto closed 2 years ago

windsto commented 4 years ago

Dear Team:

SEEGA was failed in the new veision of Slicer 4.11.20200930

OS: WIN10

无标题

BushraR commented 4 years ago

Similar problem with macox for 4.11 release. It seems to be that the extension needs to be ported for python3

Traceback (most recent call last): File "", line 1, in File "/Applications/Slicer.app/Contents/lib/Python/lib/python3.6/imp.py", line 170, in load_source module = _exec(spec, sys.modules[name]) File "", line 618, in _exec File "", line 674, in exec_module File "", line 781, in get_code File "", line 741, in source_to_code File "", line 219, in _call_with_frames_removed File "/Users/busria/Downloads/SEEGA-master/BrainZoneDetector/BrainZoneDetector.py", line 52 print self.lutPath ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print(self.lutPath)? Traceback (most recent call last): File "", line 1, in File "/Applications/Slicer.app/Contents/lib/Python/lib/python3.6/imp.py", line 170, in load_source module = _exec(spec, sys.modules[name]) File "", line 618, in _exec File "", line 674, in exec_module File "", line 781, in get_code File "", line 741, in source_to_code File "", line 219, in _call_with_frames_removed File "/Users/busria/Downloads/SEEGA-master/ContactPositionEstimator/ContactPositionEstimator.py", line 223 self.electrodeList = sorted(self.electrodeList,key=lambda (x): x.name.text) ^ SyntaxError: invalid syntax Traceback (most recent call last): File "", line 1, in File "/Applications/Slicer.app/Contents/lib/Python/lib/python3.6/imp.py", line 170, in load_source module = _exec(spec, sys.modules[name]) File "", line 618, in _exec File "", line 674, in exec_module File "", line 781, in get_code File "", line 741, in source_to_code File "", line 219, in _call_with_frames_removed File "/Users/busria/Downloads/SEEGA-master/Finalizer/Finalizer.py", line 184 print "SPLITTING FIDUCIAL FILES" ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print("SPLITTING FIDUCIAL FILES")? Traceback (most recent call last): File "", line 1, in File "/Applications/Slicer.app/Contents/lib/Python/lib/python3.6/imp.py", line 170, in load_source module = _exec(spec, sys.modules[name]) File "", line 618, in _exec File "", line 674, in exec_module File "", line 781, in get_code File "", line 741, in source_to_code File "", line 219, in _call_with_frames_removed File "/Users/busria/Downloads/SEEGA-master/GMPIComputation/GMPIComputation.py", line 184 print "RUN GMPI Computation" ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print("RUN GMPI Computation")?

BushraR commented 4 years ago

Hello I have ported the Contact Position Estimator and Brain Zone Detector modules for Slicer 4.11 (for mac). I could add it to Pull request if allowed.

hamandik commented 3 years ago

I have just encountered same problem as windsto on Slicer 4.11.20200930. I can't foliow the thread to see what I need to do, are there a ported files I should be using? Screenshot 2021-03-07 at 21 06 40

BushraR commented 3 years ago

Slicer 4.11 is based on newer version of Python, whereas current SEEGA is based on previous python version. I made small changes to fix python version mismatches and little bit of slicer updates in ContactPositionEstimator.py and BrainZoneDetector.py file. I could share the files if you are interested.

hamandik commented 3 years ago

thank you, yes please, that would be very helpful if you could share files for these.

windsto commented 3 years ago

That's great. Thanks for your sharing. How can we get these files? On 3/8/2021 17:32,BushraRnotifications@github.com wrote:

Slicer 4.11 is based on newer version of Python, whereas current SEEGA is based on previous python version. I made small changes to fix python version mismatches and little bit of slicer updates in ContactPositionEstimator.py and BrainZoneDetector.py file. I could share the files if you are interested.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

BushraR commented 3 years ago

https://www.dropbox.com/sh/wlhml1r1uxjzmuc/AACtX1qyHSvHd8G6Ixxuwh-Xa?dl=0 Let me know if it works

windsto commented 3 years ago

Great, it's working well

Many times, the contacts are not in a straight line, just like the image in the attachment. So I have a suggestion. The position of the contact can be calculated directly from the spatial coordinates of the TIP and the SKULL ENTRY? Don't rely on CT images and thresholds, just like another software, Brainstorm.The calculation process is also in the attachment. 刘强强

windsto@163.com | 签名由网易邮箱大师定制 On 3/10/2021 16:58,BushraRnotifications@github.com wrote:

https://www.dropbox.com/sh/wlhml1r1uxjzmuc/AACtX1qyHSvHd8G6Ixxuwh-Xa?dl=0 Let me know if it works

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

greydongilmore commented 3 years ago

@mnarizzano is this repo still being maintained? It would be great to have the two open PRs looked at.. one fixes this Slicer version error and the other is a useful addition to store the electrode info in the description field of the markups list.

MShabana90 commented 2 years ago

@mnarizzano @gabri470 This is a very interesting program. I am interested in learning how to use it. I am not sure if anyone has a tutorial of how to use the program. Currently an Epilepsy fellow and I am using Freesurfer for SEEG reconstructions however this seems like it would be a lot faster and easier to use. Not sure if anyone could help by posting a tutorial or video of how to use the program.

Also of note, the finalizer and GMPIcomputation are still not loading for me in modules. Not sure if anyone has a fix for these.

mosenco commented 2 years ago

The update of SEEGA is now available and working for the newest Slicer 5.0.3