search

mnasyrov / karma-jasmine-spec-tags

A plugin for karma-jasmine which helps to filter tests (specs) by tags.
MIT License
6 stars 1 forks source link

Tags not ignored with karma-jasmine 3.1 #7

Closed rajsite closed 4 years ago

rajsite commented 4 years ago

While updating my devDependencies to latest I found that if I update karma-jasmine to latest (v3.1.0) that my --skipTags are no longer functional.

Staying at karma-jasmine 2.0.1 or upgrading to karma-jasmine 3.0.3 seem to work with karma-jasmine-spec-tags but when using karma-jasmine 3.1.0 my skipped tags are no longer skipped.

mnasyrov commented 4 years ago

As I see the latest karma-jasmine changed a way to configure jasmine environment. It takes a time to fix.

lgrignon commented 4 years ago

Hello, Is there any progress on this please? :)

(In the mean time, I rollbacked my karma-jasmine to 3.0.3 and it works. Thank you for this nice plugin!)

mnasyrov commented 4 years ago

@rajsite @lgrignon I opened PR #9 with a fix. Can you pull this branch and test in your environments?

npm install https://github.com/mnasyrov/karma-jasmine-spec-tags/tarball/fix/specFilter-injection

The fix should work with all karma-jasmine versions, so it will be a minor release.

lgrignon commented 4 years ago

It works perfectly, thanks a lot! :)

lgrignon commented 4 years ago

Could you please notify here when released? Thanks again

mnasyrov commented 4 years ago

Published as karma-jasmine-spec-tags@1.3.0

lgrignon commented 4 years ago

thanks :)