search

mnauw / git-remote-hg

Transparent bidirectional bridge between Git and Mercurial for Git
GNU General Public License v2.0
62 stars 5 forks source link

A bit of python3 compatibility #19

Closed azmeuk closed 4 years ago

azmeuk commented 6 years ago

Mainly it sets parenthesis to the print function, but it also prefers next(foobar) to foobar.next().

This was automatically generated by the command futurize -1 -w -n git-hg-helper git-remote-hg from the python-future project.

catskul commented 5 years ago

Any reason this shouldn't be merged?

mnauw commented 5 years ago

I have been "slightly" delaying on this because upstream Mercurial is not yet production-ready on Python 3 (by their own claim only beta stage). So, this serves as a reminder of keeping an eye on that and then carrying it all the way to python 3 (and testing). Until all is fully Python 3 ready, adding python 3 compatibility such as in this commit is possible, but at the expense of an additional import without then providing actual python 3 capability.

And indeed, such additional import may seem trivial, but it might not be so on older installations. In any case, it's still a reminder then ...

mnauw commented 4 years ago

Thanks for the input on this, but it turns out that python3 compatibility (and in particular the Mercurial approach to it) involved a somewhat different path, not in the least wrt bytes/str handling.