search

mndrix / golog

Prolog interpreter in Go
MIT License
374 stars 39 forks source link

optimize code representations #13

Open mndrix opened 11 years ago

mndrix commented 11 years ago

Codes and lists of codes are both common Prolog data structures. Create internal representations which optimize for this use case. These representations will occupy less memory (the bottleneck in most benchmarks).

Make a Code type which implements the Number interface. It should just be a rune under the hood. The current implementation for integers requires a pointer to a struct which wraps a bool and a slice. A Code type would also be helpful for representing small integers, which are very common in real world code.

Make a CodeList which implements the Callable interface. It should just be a []rune under the hood. Unification with other list terms returns a slice where possible. The current implementation for code lists requires a linked list of terms which adds substantial memory overhead.

mndrix commented 11 years ago

Performing arithmetic operations on Code values should upgrade them to standard integers. Codes are almost never used for math. Although perhaps upgrading and repeating on overflow might be better.

ghost commented 7 years ago

Are you still working on this / have you made any progress?

I've written some helper functions for more compact printing of lists and strings. If you are interested, I could put it into a pull request.

mndrix commented 7 years ago

Are you still working on this / have you made any progress?

No. I haven't worked on this issue in quite a while and probably won't return to it in the foreseeable future.

I've written some helper functions for more compact printing of lists and strings. If you are interested, I could put it into a pull request.

Yes please. I've very interested in seeing pull requests.