Add Compumedics types and remove sample TMS type

mne-tools / fiff-constants

Bookkeeping and documentation of FIFF file format constants

4 stars 12 forks source link

Add Compumedics types and remove sample TMS type #13

Closed LorenzE closed 5 years ago

larsoner commented 5 years ago

Looks good to me.

@jnenonen @mkajola are you okay with these new constants for this system?

larsoner commented 5 years ago

(And removing a constant that isn't really used, that I recently added -- sorry about that!)

jnenonen commented 5 years ago

Suggestion: 1) can you consider using values 9101 and 9102 for compumedics coil types, 2) reserve the free'ed value 8001 for QuSpin OPM?

LorenzE commented 5 years ago

@jnenonen Both suggestions are fine with me. @larsoner If you agree I will change the current PRs (fiff_constants, mne-python, mne-cpp) and recompute the coil_def.dat with @mshamalainen

larsoner commented 5 years ago

It looks like the rule of thumb is each manufacturer gets a range starting with 1000. So if Compumedics makes the KRISS sensor (9001) then I agree 9101/9102 are good choices. Otherwise 9101/9102 do not seem to fit the pattern.