search

mne-tools / fiff-constants

Bookkeeping and documentation of FIFF file format constants
4 stars 12 forks source link

BUG: Missing entries in coil_def.dat` #14

Closed larsoner closed 5 years ago

larsoner commented 5 years ago

The coil_def.dat in MNE does not have entries for coil_type:

@jnenonen can these be removed, or do you have the appropriate coil defs for these coils?

jnenonen commented 5 years ago

Please remove these, they are not in use yet and concern only one specific prototype system.

jnenonen commented 5 years ago

Hi, Just looking at the defs:

baby_grad           7001  "Baby-SQUID gradiometer"
baby_mag_inner      7002  "BabyMEG inner layer magnetometer"
baby_mag_outer      7003  "BabyMEG outer layer magnetometer"
baby_mag_ref        7004  "BabyMEG reference layer magnetometer"
artemis123_grad     7501  "Artemis123 gradiometer"
artemis123_ref_mag  7502  "Artemis123 reference magnetometer"
artemis123_ref_grad 7503  "Artemis123 reference gradiometer"
kriss_grad          9001  "KRISS gradiometer"
compumedics_adult_grad      10001  "Compumedics adult gradiometer"
compumedics_pediatric_grad  10002  "Compumedics pediatric gradiometer"

1) Can we reserve range 8001 - 8999 for OPM sensors? 2) Is there particular need to go beyond 10000; i.e. are compumedics defs already in use somewhere? If not, I would suggest to move them e.g. to 10001->9101 and 10002->9102.

agramfort commented 5 years ago

ok for me to keep OPMs in 8000 range but I don't know who added the compumedics constants.

any idea @mshamalainen @larsoner or maybe @LorenzE ?

LorenzE commented 5 years ago

We added the compumedics coils after talking to Michael Wagner (Software dev at Compumedics) at BIOMAG 2018. If this is still of interest I can shoot him a message and get his opinion on the matter.