search

mne-tools / fiff-constants

Bookkeeping and documentation of FIFF file format constants
4 stars 12 forks source link

mne.Info - offer more complete options for subject handedness #25

Closed dominikwelke closed 4 years ago

dominikwelke commented 4 years ago

dear all, first of all thanks for your amazing work!

I find in the api documentation that mne.Info objects currently only allow two options for a subjects handedness:

hand : int Handedness (1=right, 2=left).

is there a specific reason for this? otherwise I would propose adding additional / more complete options:

hand : int Handedness (0=n/a, 1=right, 2=left, 3=ambidextrous).

best, Dominik

larsoner commented 4 years ago

We follow the official FIFF definitions, so we would need to add it there:

https://github.com/mne-tools/fiff-constants/blob/064604db8aeba310c76c93e7c76cc983257105b4/DictionaryTypes.txt#L453-L457

Okay if I transfer the issue there?

hoechenberger commented 4 years ago

+1 on moving it over there.

btw I believe a similar adjustment could and should be made to the "sex" variable. Will open an issue over at fiff-constants too when I find the time.

dominikwelke commented 4 years ago

@larsoner yes, this would be great. thanks for forwarding this to the right address!

@hoechenberger +1 on adding "sex" options, I thought of this as well

larsoner commented 4 years ago

cc @jnenonen any thoughts on expanding the list of handedness to include ambidextrous, and possible other option(s) to sex in the subject info fields?

jnenonen commented 4 years ago

Hi Eric,

Please feel free to add suggestions for the next FIFF dictionary.

BR, Jukka

[cid:image002.png@01D5EAF0.136FC3C0]

From: Eric Larson notifications@github.com Sent: 24. helmikuutata 2020 3:56 To: mne-tools/fiff-constants fiff-constants@noreply.github.com Cc: Jukka Nenonen jukka.nenonen@megin.fi; Mention mention@noreply.github.com Subject: Re: [mne-tools/fiff-constants] mne.Info - offer more complete options for subject handedness (#25)

cc @jnenonenhttps://github.com/jnenonen any thoughts on expanding the list of handedness to include ambidextrous, and possible other option(s) to sex in the subject info fields?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mne-tools/fiff-constants/issues/25?email_source=notifications&email_token=ADR3D6WOT3TCG35VYN5ICGLREMSJLA5CNFSM4KZ737R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWOJ4Q#issuecomment-590144754, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADR3D6UPPDBN7FCDV6MG75LREMSJLANCNFSM4KZ737RQ.

larsoner commented 4 years ago

@dominikwelke can you open a PR for handedness?

@hoechenberger can you make one for sex?

dominikwelke commented 4 years ago

see #26