ENH: Add new OPMs - Githubissues

larsoner commented 3 years ago

@mkajola @jnenonen okay for you? It breaks from our "1000-per-manufacturer" scheme, but keeps us < 10000, which is nice. This keeps OPMs grouped in the 8000 range, giving each manufacturer there a block of 100, which seems adequate.

jnenonen commented 3 years ago

Hi Eric,

Fine with me.

BR, Jukka

[A screenshot of a cell phone Description automatically generated]--

From: Eric Larson @.> Reply to: mne-tools/fiff-constants @.> Date: Wednesday 12. May 2021 at 16.13 To: mne-tools/fiff-constants @.> Cc: Jukka Nenonen @.>, Mention @.***> Subject: [mne-tools/fiff-constants] ENH: Add new OPMs (#35)

@mkajolahttps://github.com/mkajola @jnenonenhttps://github.com/jnenonen okay for you? It breaks from our "1000-per-manufacturer" scheme, but keeps us < 10000, which is nice. This keeps OPMs grouped in the 8000 range, giving each manufacturer there a block of 100, which seems adequate.

You can view, comment on, or merge this pull request online at:

https://github.com/mne-tools/fiff-constants/pull/35

Commit Summary

ENH: Add new OPMs

File Changes

M DictionaryTypes.txthttps://github.com/mne-tools/fiff-constants/pull/35/files#diff-eb9545a3fbc15857df72863b5a9a516e8c305bc20e08eaa12966c89eed434264 (2)

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mne-tools/fiff-constants/pull/35, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADR3D6RNB3ZT7S5QTSTJ6X3TNJ5IJANCNFSM44YSSIVA.

mkajola commented 3 years ago

Hello, FIne for me too.

We are busy in planning days today and tomorrow. For my part you can mark this accepted somehow if you can. If you need us to mark it ok in github, please let us know.

t. mjk

From: Jukka Nenonen @.> Sent: maanantai 17. toukokuuta 2021 8.05 To: mne-tools/fiff-constants @.> Cc: Matti Kajola @.>; Mention @.> Subject: Re: [mne-tools/fiff-constants] ENH: Add new OPMs (#35)