search

mne-tools / fiff-constants

Bookkeeping and documentation of FIFF file format constants
4 stars 12 forks source link

[ENH] Add new raw sfreq for Epochs #37

Closed adam2392 closed 2 years ago

adam2392 commented 2 years ago

Merging in new constant to store the raw sampling rate for Epochs to enable storage of Annotations within MNE Epochs.

Reference: https://github.com/mne-tools/mne-python/pull/10019/

adam2392 commented 2 years ago

cc: @larsoner @agramfort

larsoner commented 2 years ago

FYI @jnenonen we're adding one constant to the MNE constant range. I assume it's okay for us to self-merge this, but if not, let me know for next time! I doubt we'll add constants very often.

jnenonen commented 2 years ago

Hi Eric,

Fine with me,

BR, Jukka

[Text Description automatically generated]

From: Eric Larson @.> Reply to: mne-tools/fiff-constants @.> Date: Friday 7. January 2022 at 21.17 To: mne-tools/fiff-constants @.> Cc: Jukka Nenonen @.>, Mention @.***> Subject: Re: [mne-tools/fiff-constants] [ENH] Add new raw sfreq for Epochs (PR #37)

FYI @jnenonenhttps://github.com/jnenonen we're adding one constant to the MNE constant range. I assume it's okay for us to self-merge this, but if not, let me know for next time! I doubt we'll add constants very often.

— Reply to this email directly, view it on GitHubhttps://github.com/mne-tools/fiff-constants/pull/37#issuecomment-1007670911, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADR3D6U6VGT56XN3EWMMYILUU4355ANCNFSM5LND7WYA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

mkajola commented 2 years ago

Yep. You can. I think you can in principle add what you like into MNE section. But it is a good idea to first think if the additions are so general, that they should be added to the “base” fiff spec for everybody to use. And is some rare cases may be able to propose some even better solutions. t. mjk

From: Eric Larson @.> Sent: perjantai 7. tammikuuta 2022 21.18 To: mne-tools/fiff-constants @.> Cc: Subscribed @.***> Subject: Re: [mne-tools/fiff-constants] [ENH] Add new raw sfreq for Epochs (PR #37)

FYI @jnenonenhttps://github.com/jnenonen we're adding one constant to the MNE constant range. I assume it's okay for us to self-merge this, but if not, let me know for next time! I doubt we'll add constants very often.

— Reply to this email directly, view it on GitHubhttps://github.com/mne-tools/fiff-constants/pull/37#issuecomment-1007670911, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKJMTHAHQLNS7S7AS3H33K3UU4355ANCNFSM5LND7WYA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>