`_audiovis_` naming

[massich]

In the files that we genrate _audiovis_ is all over the place.

ie:

https://github.com/mne-tools/mne-study-template/blob/f33cb39a12419ab56a399de0ccf8a860a9137af0/02-apply_maxwell_filter.py#L32

Should the code be example agnostic? or is it really part of the example?

[agramfort]

we could make raw file nmaes part of the config but I think that it should be fixed iwth bids datasets as it standardizes file namings

[SophieHerbst]

I think we should make sure to offer the possibility to put a custom user name in the config. Ideally that also works with bids then.

[SophieHerbst]

I think we need to a) tell users how to organize their data (MEG/sb_name/subfolders) b) write the code such that it automatically finds the raw files for the number of runs that are there This is difficult to implement with the audiovis sample. Is the study data online?

[jasmainak]

We should write code to do this :) But the group study data is unfortunately humongous for software development

On Wed 6 Feb 2019 at 11:28, Sophie Herbst notifications@github.com wrote:

I think we need to a) tell users how to organize their data (MEG/sb_name/subfolders) b) write the code such that it automatically finds the raw files for the number of runs that are there This is difficult to implement with the audiovis sample. Is the study data online?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-study-template/issues/16#issuecomment-461088651, or mute the thread https://github.com/notifications/unsubscribe-auth/APHiopIgMwunL8OrtueFHw2F5ugRuyDgks5vKwLBgaJpZM4ak79q .

-- Sent from my iPhone

[massich]

At this point I think we should shoot for the very minimal. IMHO: sample stripping all we can from all the naming (and maybe set the naming formatting string at the top of each script).

Call it versión 0.0-rc1, And then see where can we go from there.

On Wed, Feb 6, 2019, 18:42 Mainak Jas notifications@github.com wrote:

We should write code to do this :) But the group study data is unfortunately humongous for software development

On Wed 6 Feb 2019 at 11:28, Sophie Herbst notifications@github.com wrote:

I think we need to a) tell users how to organize their data (MEG/sb_name/subfolders) b) write the code such that it automatically finds the raw files for the number of runs that are there This is difficult to implement with the audiovis sample. Is the study data online?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/mne-tools/mne-study-template/issues/16#issuecomment-461088651 , or mute the thread < https://github.com/notifications/unsubscribe-auth/APHiopIgMwunL8OrtueFHw2F5ugRuyDgks5vKwLBgaJpZM4ak79q

.

-- Sent from my iPhone

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-study-template/issues/16#issuecomment-461094145, or mute the thread https://github.com/notifications/unsubscribe-auth/AGt-4_0-RY0EA3Dg80FBHG0D8v0ALYIAks5vKwYEgaJpZM4ak79q .

[SophieHerbst]

I will make a suggestion and ask you to polish it.

[massich]

I think this is addressed by study_name in #19. closing. Feel free to reopen if I missed something.

[SophieHerbst]

File naming could still be clarified. How about we only generate one base_name in config and add the endings in each scripts? Instead of this:

base_raw_fname = '{subject}_' + study_name + '{run}_raw.fif'
base_epochs_fname = '{subject}_' + study_name + '_epo.fif'
base_ave_fname = '{subject}_' + study_name + '_ave.fif'

[SophieHerbst]

also, do you insist on the ending being -epo.fif instead of _epo.fif?

[jasmainak]

is there something to still do here @SophieHerbst ? perhaps if you have a moment, it would be helpful to give some feedback that @sappelhoff could incorporate in his last week of gsoc?

[SophieHerbst]

From a quick look into the code the issue looks solved. I didn't have the time to run it yet.

[jasmainak]

okay closing for now. Feel free to reopen if you disagree later.