[x] Changelog has been updated (docs/source/changes.md)
I went to work on #574 and the sheer volume of kwargs in get_config that must be used to import_*_data made it really hard to start from one of the steps/preprocessing/*.py files to add a new step. This PR is a no-op from the user standpoint but refactors to:
_bids_kwargs function that returns some standard BIDS kwargs like cfg.space. Eventually we should use this everywhere probably but I'm just starting with steps/preprocessing for now.
_import_data_kwargs function that gets the config params needed for reading raw data
Should be a lot more red than green here. I don't expect the first version to pass -- locally I've only run ds004229 -- but hopefully it won't require many more iterations to get right!
Before merging …
docs/source/changes.md)I went to work on #574 and the sheer volume of
kwargsinget_configthat must be used toimport_*_datamade it really hard to start from one of thesteps/preprocessing/*.pyfiles to add a new step. This PR is a no-op from the user standpoint but refactors to:_bids_kwargsfunction that returns some standard BIDS kwargs likecfg.space. Eventually we should use this everywhere probably but I'm just starting withsteps/preprocessingfor now._import_data_kwargsfunction that gets theconfigparams needed for reading raw dataShould be a lot more red than green here. I don't expect the first version to pass -- locally I've only run
ds004229-- but hopefully it won't require many more iterations to get right!