Closed larsoner closed 1 year ago
@larsoner I'm wondering if we shouldn't add part of this upstream to mne.Report
? I got this impression when I saw you injecting custom HTML. – It's an open question, I'm not entirely sure about the best approach myself. WDYT?
Indeed in principle people could want to automatically gain some notes about raw
annotations. In principle we could maybe add some logic to report.add_raw
to autodetect the built-in annot types we have, but for example it would miss the limit
that I inject here. Or if users have done their own annotations they'll have to write custom code anyway. So there is a deeper API discussion to be had. My inclination is to add stuff here first and if people think it's useful generally then we can add it upstream and remove our "custom" code here
Thanks @larsoner
Before merging …
docs/source/changes.md
)With updated vals for
ds004229
:During the run we see:
And in the report we get: