search

mne-tools / mne-bids-pipeline

Automatically process entire electrophysiological datasets using MNE-Python.
https://mne.tools/mne-bids-pipeline/
BSD 3-Clause "New" or "Revised" License
137 stars 65 forks source link

Add `"autoreject_local"` as new option for `preprocessing/ptp_reject` #807

Closed hoechenberger closed 10 months ago

hoechenberger commented 10 months ago

Before merging …

closes #410

cc @dengemann

hoechenberger commented 10 months ago

@larsoner I'm not sure how to modify _config_import.py in order to fix this test:

https://github.com/mne-tools/mne-bids-pipeline/actions/runs/6733693944/job/18302967345?pr=807

Could you help me out here, please?

hoechenberger commented 10 months ago

Thanks @larsoner

hoechenberger commented 10 months ago

Tests currently failing because of https://github.com/autoreject/autoreject/issues/320

hoechenberger commented 10 months ago

@larsoner I believe the CI error may have to do with https://github.com/mne-tools/mne-python/pull/12156 These errors did not occur before that PR was merged :(

hoechenberger commented 10 months ago

@agramfort @larsoner Output looks like this:

https://output.circle-artifacts.com/output/job/26a8def0-8c16-44f2-917c-a197c07c406c/artifacts/0/reports/ERP_CORE/sub-015_ses-N400_task-N400_report.html#Epochs__Autoreject_cleaning

I think it's nice! Only quite a bit of whitespace around the figure. Is this something we should look to fix upstream in autoreject?

hoechenberger commented 10 months ago

Output looks like this now: https://output.circle-artifacts.com/output/job/801b300e-8885-4e8c-a6e0-61648f3d69f0/artifacts/0/reports/ERP_CORE/sub-015_ses-N400_task-N400_report.html#Epochs__Autoreject_cleaning

I just restarted CI to take advantage of https://github.com/mne-tools/mne-python/pull/12167

hoechenberger commented 10 months ago

We're green!

hoechenberger commented 10 months ago

@larsoner I've addressed your comments