mne-tools / mne-bids-pipeline

Automatically process entire electrophysiological datasets using MNE-Python.
https://mne.tools/mne-bids-pipeline/
BSD 3-Clause "New" or "Revised" License
137 stars 65 forks source link

Add support for MNE-ICALabel #812

Open hoechenberger opened 10 months ago

hoechenberger commented 10 months ago

Before merging …

hoechenberger commented 10 months ago

@larsoner I'm not sure why this one test fails, could you help me out here please? :) https://github.com/mne-tools/mne-bids-pipeline/actions/runs/6798018175/job/18481346112?pr=812

hoechenberger commented 10 months ago
larsoner commented 10 months ago

It only looks for items that are ast.AnnAssign so it's because you did not type annotate. I added a test that will check this more explicitly and fixed the error

hoechenberger commented 10 months ago

Thanks @larsoner!!

larsoner commented 10 months ago

Also @hoechenberger we are almost through all of our 250,000 paid CircleCI compute credits for Nov mostly from MNE-BIDS-Pipeline usage (141,856 MBP vs 46,692 for MNE), so if there is any way you could push less often and do more local testing it would be greatly appreciated :pray:

hoechenberger commented 10 months ago

Argh ok will try

behinger commented 3 months ago

hey! I tried to merge the newest changes in mne_bids_pipeline into this branch to make use if icalabel - but it is more tricky than anticipated because quite some code got moved around and I am not familiar with the code-base.

Any chance you have some newer local version already merged? If not, I will dig deeper into the code-base

Cheerio!

hoechenberger commented 2 months ago

Hey @behinger, we did some serious refactoring of the ICA-related project organization. I believe it would be easier to start a new PR based off of the latest main branch than trying to fix this one…

behinger commented 2 months ago

Okay, thanks for the response! We're (with @jschepers) looking into it :-)