mne-tools / mne-bids-pipeline

Automatically process entire electrophysiological datasets using MNE-Python.
https://mne.tools/mne-bids-pipeline/
BSD 3-Clause "New" or "Revised" License
133 stars 65 forks source link

ENH: Document relevant steps #866

Closed larsoner closed 4 months ago

larsoner commented 4 months ago

Before merging …

Closes #862

Examples:

Screenshot from 2024-02-29 14-59-38

Screenshot from 2024-02-29 14-57-21

(I didn't realize use_maxwell_filter had a direct impact on the CSP step but it does because we pick mag there if it's used!)

Draft because I need to parse a few functions for config defs but that's a tiny detail -- the general idea and code is otherwise reviewable.

larsoner commented 4 months ago

Okay it was easier than I thought to parse the helper functions, ready for review/merge from my end @hoechenberger !

larsoner commented 4 months ago

Also with this in place we should maybe rethink some of our categorization, for example eog_channels is only used for artifact detection:

Screenshot from 2024-02-29 15-55-36

Maybe it should live in the artifacts section.

hoechenberger commented 4 months ago

I will take a look at this shortly

Thanks for your effort, Eric

larsoner commented 4 months ago

Okay I pushed with abstract, feel free to mark for merge-when-green if you're happy @hoechenberger !