search

mne-tools / mne-bids-pipeline

Automatically process entire electrophysiological datasets using MNE-Python.
https://mne.tools/mne-bids-pipeline/
BSD 3-Clause "New" or "Revised" License
133 stars 65 forks source link

Improve logging output when rejecting epochs; and log number of reconstructed ICA and SSP epochs #936

Closed hoechenberger closed 2 months ago

hoechenberger commented 2 months ago

quite some duplication … but Logging is better

┌────────┬ preprocessing/_09_ptp_reject ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
│21:45:35│ ⏳️ sub-005 Input:  sub-005_task-tasin_proc-ica_epo.fif
│21:45:35│ ⏳️ sub-005 Output: sub-005_task-tasin_proc-clean_epo.fif
│21:45:36│ ⏳️ sub-005 Removed 4 of 240 epochs via PTP rejection thresholds: {'eeg': 0.00025}
│21:45:36│ ⏳️ sub-005 Adding cleaned epochs to report.

Before merging …

larsoner commented 2 months ago

Same failure on three CIs @hoechenberger

https://app.circleci.com/pipelines/github/mne-tools/mne-bids-pipeline/4521/workflows/7b628b2f-557d-4b5e-99fc-8ca9cfc39212/jobs/65183

You know how to raise this as an issue with the OpenNeuro folks?

hoechenberger commented 2 months ago

Same failure on three CIs @hoechenberger

https://app.circleci.com/pipelines/github/mne-tools/mne-bids-pipeline/4521/workflows/7b628b2f-557d-4b5e-99fc-8ca9cfc39212/jobs/65183

You know how to raise this as an issue with the OpenNeuro folks?

Yes I can take care of this tomorrow!

Any input on this PR content?

It's not DRY at all, but I'm also not convinced that adding yet another helper function would be beneficial – the pipeline complexity is already too much for me sometimes :(

larsoner commented 2 months ago

Looks reasonable to me so far. I don't see a convincingly cleaner way to make it more DRY anyway

hoechenberger commented 2 months ago

@larsoner I marked this for auto-merge, I hope this is okay with you! Otherwise feel free to let me know and I can revert.

hoechenberger commented 2 months ago

@larsoner Tracking the OpenNeuro issue at https://github.com/OpenNeuroOrg/openneuro/issues/3033

larsoner commented 2 months ago

Failure is just downloading 246 and I can't imagine that would fail given the others passed with these changes so I'll merge, thanks @hoechenberger !