search

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
131 stars 85 forks source link

get_entity_vals() does not support the 'recording' entity #1172

Closed moritz-gerster closed 10 months ago

moritz-gerster commented 11 months ago

Describe the problem

get_entity_vals(load_root, "recording")

ValueError: `key` must be one of: subject, task, session, run, processing, space, acquisition, split, description, suffix. Got: recording

Describe your solution

I would expect that get_entity_vals() works for all entities. Not sure why 'recording' is excluded.

Describe possible alternatives

Maybe also add the 'extension' and 'datatype' entity?

Additional context

No response

hoechenberger commented 11 months ago

@moritz-gerster Would you like to try fixing this in a PR?

moritz-gerster commented 11 months ago

I am sorry @hoechenberger, I am currently too busy to do it..

hoechenberger commented 11 months ago

Maybe also add the 'extension' and 'datatype' entity?

These are not entities.

We should add recording though

Deadr4x commented 11 months ago

Hello would this be good as my first issue? I would like to contribute.

agramfort commented 11 months ago

yes !

Message ID: @.***>

Deadr4x commented 11 months ago

I did setup the project locally and managed to replicate the error message. Will look into that.

sappelhoff commented 10 months ago

@Deadr4x are you still interested in contributing this pull request? Else, I will take over. :-)