[MRG] Add recording entity to get_entity_vals

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.

https://mne.tools/mne-bids/

BSD 3-Clause "New" or "Revised" License

131 stars 85 forks source link

[MRG] Add recording entity to get_entity_vals #1182

Closed sappelhoff closed 10 months ago

sappelhoff commented 10 months ago

PR Description

closes #1172

Merge checklist

Maintainer, please confirm the following before merging. If applicable:

[ ] All comments are resolved
[x] This is not your own PR
[ ] All CIs are happy
[x] PR title starts with [MRG]
[x] whats_new.rst is updated
[x] New contributors have been added to CITATION.cff
[x] PR description includes phrase "closes <#issue-number>"

codecov[bot] commented 10 months ago

Codecov Report

Merging #1182 (b69c14d) into main (80add0f) will decrease coverage by 0.02%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   97.63%   97.62%   -0.02%     
==========================================
  Files          40       40              
  Lines        8661     8664       +3     
==========================================
+ Hits         8456     8458       +2     
- Misses        205      206       +1

Files	Coverage Δ
mne_bids/path.py	`97.27% <80.00%> (-0.11%)`	:arrow_down:

moritz-gerster commented 10 months ago

Nice, thank you for solving my issue @sappelhoff! :)

sappelhoff commented 10 months ago

Nice, thank you for solving my issue @sappelhoff! :)

took some time yesterday morning before the presentations ;-)