Closed laemtl closed 9 months ago
Thanks!
Please add a test to this existing testing infrastructure: https://github.com/mne-tools/mne-bids/blob/b96c48908b984516bac654d248610e2aa1401b9f/mne_bids/tests/test_write.py#L1369-L1380
you should be able to simply add to these data: https://github.com/mne-tools/mne-bids/blob/b96c48908b984516bac654d248610e2aa1401b9f/mne_bids/tests/test_write.py#L148-L173
Please also add an entry to the changelog: https://github.com/mne-tools/mne-bids/blob/main/doc/whats_new.rst
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
5ad1db4
) 97.64% compared to head (67dc2a5
) 97.64%.
Files | Patch % | Lines |
---|---|---|
mne_bids/write.py | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
HDF5 support is not provided yet.
perhaps you could open an issue on https://github.com/jackz314/eeglabio and ask whether support could be added there.
I personally think it'd be great to include that.
HDF5 support is not provided yet.
perhaps you could open an issue on https://github.com/jackz314/eeglabio and ask whether support could be added there.
I personally think it'd be great to include that.
I totally agree :)
@laemtl gentle reminder :-)
perhaps you could open an issue on https://github.com/jackz314/eeglabio and ask whether support could be added there.
I personally think it'd be great to include that.
I've done that now, please see: https://github.com/jackz314/eeglabio/issues/10
I have also pushed some commits to point you in the right direction, please feel free to continue once you have time.
PS: If you do want to continue work on this, you will need to sync your local git repo with your branch again, because I force pushed some changes.
You can do it (locally) like this:
git reset --hard origin/eeglab.export
PR Description
Add support for EEGLAB files (for preloaded .set files) in write_raw_bids HDF5 support is not provided yet.
Closes #1152
Merge checklist
Maintainer, please confirm the following before merging. If applicable: