search

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
132 stars 86 forks source link

FutureWarning: with copy=False --> set default explicity #1190

Closed sappelhoff closed 11 months ago

sappelhoff commented 11 months ago

https://github.com/mne-tools/mne-bids/actions/runs/6845626385/job/18611114921#step:20:510

FutureWarning: The current default of copy=False will change to copy=True in 1.7. Set the value of copy explicitly to avoid this warning

affects all get_data calls for Epochs

drammock commented 11 months ago

cross-ref https://github.com/mne-tools/mne-python/pull/12121

larsoner commented 11 months ago

I'll take a look.

@sappelhoff WDYT about cutting a MNE-BIDS point release today or tomorrow so the copy=False fix can make it into the 1.6 installers?

sappelhoff commented 11 months ago

sure, I can make a 0.13.1 release once the copy=False fix is in 👍

larsoner commented 11 months ago

... actually it looks like the failure is just in a test not in the code itself so I don't think a release will be necessary

sappelhoff commented 11 months ago

even better :-)