[MRG] add CSS to truncate long version string

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.

https://mne.tools/mne-bids/

BSD 3-Clause "New" or "Revised" License

131 stars 85 forks source link

[MRG] add CSS to truncate long version string #1206

Closed drammock closed 9 months ago

drammock commented 9 months ago

PR Description

closes #1205 by truncating long version strings (with text-overflow: ellipsis)

Merge checklist

Maintainer, please confirm the following before merging. If applicable:

[x] All comments are resolved
[x] This is not your own PR
[x] All CIs are happy
[x] PR title starts with [MRG]
[x] whats_new.rst is updated
[x] New contributors have been added to CITATION.cff
[x] PR description includes phrase "closes <#issue-number>"

welcome[bot] commented 9 months ago

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

drammock commented 9 months ago

Doc build is failing with

FileNotFoundError: File does not exist: "/home/circleci/mne_bids_env/lib/python3.9/site-packages/mne/data/fsaverage/fsaverage-fiducials.fif"

https://app.circleci.com/pipelines/github/mne-tools/mne-bids/5724/workflows/eec55885-c064-4fb8-83a2-825269e3fb48/jobs/7919

I'll push the changelog entry but @sappelhoff can you take over here?

hoechenberger commented 9 months ago

I can fix the issue

@cbrnr @larsoner @sappelhoff

larsoner commented 9 months ago

Sure, I opened https://github.com/mne-tools/mne-python/pull/12280 which will hopefully at least set up CIs to show the problem

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8321aef) 97.61% compared to head (4716860) 97.61%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1206 +/- ## ======================================= Coverage 97.61% 97.61% ======================================= Files 40 40 Lines 8685 8685 ======================================= Hits 8478 8478 Misses 207 207 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drammock commented 9 months ago

here's the rendered doc: https://output.circle-artifacts.com/output/job/a36b9461-2f17-4d84-ba0a-70d85c36c8cd/artifacts/0/dev/index.html

Looks as expected: Screenshot 2023-12-08 at 16-16-40 MNE-BIDS — MNE-BIDS 0 15 0 dev17 g47168603 documentation

codecov failure seems spurious.

welcome[bot] commented 9 months ago

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪