mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
131 stars 86 forks source link

[MRG] BUG: Fix dtype bug for counts #1227

Closed larsoner closed 7 months ago

larsoner commented 7 months ago

PR Description

Counts should be integers, make them that way by filling with -1 then converting to pandas Int64Dtype with pd.NA.

Merge checklist

Maintainer, please confirm the following before merging. If applicable:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87eea28) 97.61% compared to head (8f2655a) 97.61%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1227 +/- ## ======================================= Coverage 97.61% 97.61% ======================================= Files 40 40 Lines 8685 8686 +1 ======================================= + Hits 8478 8479 +1 Misses 207 207 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

agramfort commented 7 months ago

thx @larsoner