Run unit tests on Apple Silicon and bump Node version to LTS (currently 20)

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.

https://mne.tools/mne-bids/

BSD 3-Clause "New" or "Revised" License

126 stars 84 forks source link

Run unit tests on Apple Silicon and bump Node version to LTS (currently 20) #1231

Closed hoechenberger closed 4 months ago

hoechenberger commented 4 months ago

Merge checklist

Maintainer, please confirm the following before merging. If applicable:

[ ] All comments are resolved
[ ] This is not your own PR
[ ] All CIs are happy
[ ] PR title starts with [MRG]
[ ] whats_new.rst is updated
[ ] New contributors have been added to CITATION.cff
[ ] PR description includes phrase "closes <#issue-number>"

hoechenberger commented 4 months ago

blocked by #1233

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.59%. Comparing base (87eea28) to head (2b619a3). Report is 10 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1231 +/- ## ========================================== - Coverage 97.61% 97.59% -0.02% ========================================== Files 40 40 Lines 8685 8663 -22 ========================================== - Hits 8478 8455 -23 - Misses 207 208 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hoechenberger commented 4 months ago

@sappelhoff I will take care of the failing CI job

hoechenberger commented 4 months ago

@sappelhoff I think you merged a failing branch :) I'll open a follow-up PR to fix this

sappelhoff commented 4 months ago

urgs, sorry.

hoechenberger commented 4 months ago

urgs, sorry.

No worries, happens … I think it got auto-merged because the new CI job had naturally not been added to the branch protection rules yet!