mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
126 stars 84 forks source link

account for optional Z in time strs #1240

Closed sappelhoff closed 4 months ago

sappelhoff commented 4 months ago

PR Description

fix a problem that was reported here: https://mne.discourse.group/t/how-to-import-fnirs-data-from-a-local-dataset/8481/3?u=sappelhoff

cc @hoechenberger

Merge checklist

Maintainer, please confirm the following before merging. If applicable:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.60%. Comparing base (87eea28) to head (8566784). Report is 15 commits behind head on main.

:exclamation: Current head 8566784 differs from pull request most recent head f907308. Consider uploading reports for the commit f907308 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1240 +/- ## ========================================== - Coverage 97.61% 97.60% -0.02% ========================================== Files 40 40 Lines 8685 8682 -3 ========================================== - Hits 8478 8474 -4 - Misses 207 208 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hoechenberger commented 4 months ago

@sappelhoff I tried to give it a shot

Code isn't super pretty but I think the logical flow is very clear

Didn't run or write any tests yet

hoechenberger commented 4 months ago

I added some tests

sappelhoff commented 4 months ago

Very kind of you to include me in the commit changelog message 🤣

Thanks, I think this is much saner behavior now!!

hoechenberger commented 4 months ago

Very kind of you to include me in the ~commit~ changelog message 🤣

yeah now worries, you started the PR after all :)

Thanks, I think this is much saner behavior now!!

let's hope I / we didn't overlook something here … but I think in any case, we're behaving more correctly now than before!