search

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
126 stars 84 forks source link

Update pre-commit hooks, fix sphinx_gallery #1245

Closed pre-commit-ci[bot] closed 2 months ago

pre-commit-ci[bot] commented 3 months ago

updates:

sappelhoff commented 3 months ago

@hoechenberger there seems to be a CI issue with the inspect module -- do you have an idea what could be wrong?

drammock commented 2 months ago

CircleCI failure is 

WARNING: cannot cache unpickable configuration value: 'sphinx_gallery_conf' (because it contains a function, class, or module object)

Which should be fixed if you update sphinx gallery to have https://github.com/sphinx-gallery/sphinx-gallery/pull/1289 (see the fix in MNE-Python: https://github.com/mne-tools/mne-python/pull/12574)

@sappelhoff where are you seeing problem with inspect module?

sappelhoff commented 2 months ago

@drammock I looked into this, and potentially into the nightly CI runs as well and saw the inspect module turning up red somewhere. I can't find it anymore now, so thanks for alerting me that what I thought a bug was maybe just a CI fluke (... or my imagination).

sappelhoff commented 2 months ago

@drammock @hoechenberger I think this is the failure that threw me off recently: https://github.com/mne-tools/mne-bids/actions/runs/9106401009/job/25033546552#step:20:1185

FAILED mne_bids/tests/test_inspect.py::test_inspect_single_file[True] - matplotlib._api.deprecation.MatplotlibDeprecationWarning: Auto-close()ing of figures upon backend switching is deprecated since 3.8 and will be removed in 3.10. To suppress this warning, explicitly call plt.close('all') first. FAILED mne_bids/tests/test_inspect.py::test_inspect_single_file[False] - UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shown