search

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
131 stars 86 forks source link

Request for New Version Release on pip #1247

Closed bruAristimunha closed 4 months ago

bruAristimunha commented 5 months ago

Hello maintainers!

I've noticed that the latest changes in the source code have not yet been reflected in the pip package. These changes would be beneficial to braindecode and moabb.

We are having users with problems installing moabb/braindecode, and we cannot update mne_bids dependencies on moabb to resolve the issues because mne_bids is not compatible with the last version of mne.

Could you please release the new version of this package on pip? It seems that the current source code solves the problems.

Thank you for your time and consideration.

FYI @agramfort and @brunaafl

welcome[bot] commented 5 months ago

Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

hoechenberger commented 5 months ago

Hello,

could you please share the error you're seeing and which versions of MNE-Python and MNE-BIDS you're using?

bruAristimunha commented 5 months ago

Hey @hoechenberger,

Sure!

The error was first reported in braindecode: https://github.com/braindecode/braindecode/issues/598

Then we discovered that it came from moabb:

https://github.com/NeuroTechX/moabb/pull/586

The problem arises because braindecode has no upper limit for the version of our dependencies, and moabb has.

bruAristimunha commented 5 months ago

Report here too: https://github.com/NeuroTechX/moabb/issues/598

hoechenberger commented 5 months ago

I don't understand, at least in the last issue you posted, it's said that the problem is that MNE-BIDS 0.13 is not compatible with MNE-Python 1.7.

But the latest release of MNE-BIDS is 0.14. So I'm confused. Why don't you just install 0.14?

hoechenberger commented 5 months ago

I checked the MOABB dependencies and they specify MNE <= 1.6 and MNE-BIDS 0.13

So you're destroying MOABB's dependency chain if you're installing MNE 1.7 with it

I assume you didn't realize that because they use poetry, which is non-standard-compliant in its dependency management

bruAristimunha commented 5 months ago

Exactly!

hoechenberger commented 5 months ago

Yeah but then there's really nothing the MNE-BIDS team can do to help you here ... or am I missing something?

hoechenberger commented 5 months ago

Ah. Is it this EDF issue here that's causing the pain?

https://github.com/NeuroTechX/moabb/pull/586#issuecomment-2093108052

bruAristimunha commented 5 months ago

Exactly yes, I am copying @brunaalf if you need more details :)

hoechenberger commented 5 months ago

@sappelhoff Would you have time to cut a new release anytime soon?

sappelhoff commented 4 months ago

@hoechenberger yes, I should be able to do it within the next two weeks max.

Do you want to look into this before? https://github.com/mne-tools/mne-bids/pull/1245

something with the inspect module, I think.

sappelhoff commented 4 months ago

I started migrating some issues over to the milestone for the release AFTER the impending on: https://github.com/mne-tools/mne-bids/milestone/17

However I think there are some issues we do need to solve before a release, like: #1250

sappelhoff commented 4 months ago

@bruAristimunha mne-bids 0.15.0 has just been released! https://pypi.org/project/mne-bids/0.15.0/#history