Closed JuliusWelzel closed 1 month ago
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.45%. Comparing base (
87eea28
) to head (3a37466
). Report is 25 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hopefully all done, so should be good to go
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪
Thanks @JuliusWelzel!
PR Description
As currently implemented, the events.json file being written does not contain information about the two required columns "onset" and "duration" in the .json file.
As those columns are REQURIED, I would propose adding some background information to the .json file every time events are written for people who are not familiar with the structure of the events.tsv files in.REQUIRED.
See https://github.com/mne-tools/mne-bids/issues/1254 for details.
Merge checklist
Maintainer, please confirm the following before merging. If applicable: