mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
126 stars 84 forks source link

[MRG] auto-add event_id key for BAD_ACQ_SKIP #1258

Closed drammock closed 1 month ago

drammock commented 1 month ago

PR Description

closes #1257

write_raw_bids will now allow the situation where BAD_ACQ_SKIP annotations are present in the raw file, but no corresponding key is present in the user-passed event_id dict.

Merge checklist

Maintainer, please confirm the following before merging. If applicable:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.46%. Comparing base (87eea28) to head (aff3f57). Report is 26 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1258 +/- ## ========================================== - Coverage 97.61% 97.46% -0.16% ========================================== Files 40 40 Lines 8685 8703 +18 ========================================== + Hits 8478 8482 +4 - Misses 207 221 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drammock commented 1 month ago

IDK what codecov is complaining about: from the diff on their site it looks like 100% of the new lines are hit

sappelhoff commented 1 month ago

IDK what codecov is complaining about: from the diff on their site it looks like 100% of the new lines are hit

I find the following suspicious:

BASE commit is 26 commits behind HEAD on main c87a823

see: https://app.codecov.io/gh/mne-tools/mne-bids/pull/1258

it's using 87eea28 as the BASE commit, which is really outdated 🤔 I would have expected it to use HEAD as the BASE commit (c87a823)

drammock commented 1 month ago

all green except codecov (which as discussed is misbehaving here; PR coverage is 100%)

hoechenberger commented 1 month ago

Great, thanks, Dan!