Closed drammock closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.46%. Comparing base (
87eea28
) to head (aff3f57
). Report is 26 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
IDK what codecov is complaining about: from the diff on their site it looks like 100% of the new lines are hit
IDK what codecov is complaining about: from the diff on their site it looks like 100% of the new lines are hit
I find the following suspicious:
BASE commit is 26 commits behind HEAD on main c87a823
see: https://app.codecov.io/gh/mne-tools/mne-bids/pull/1258
it's using 87eea28 as the BASE commit, which is really outdated 🤔 I would have expected it to use HEAD as the BASE commit (c87a823)
all green except codecov (which as discussed is misbehaving here; PR coverage is 100%)
Great, thanks, Dan!
PR Description
closes #1257
write_raw_bids
will now allow the situation whereBAD_ACQ_SKIP
annotations are present in the raw file, but no corresponding key is present in the user-passedevent_id
dict.Merge checklist
Maintainer, please confirm the following before merging. If applicable: