search

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
131 stars 85 forks source link

Getting ready for schema based bids-validator #1288

Open sappelhoff opened 1 month ago

sappelhoff commented 1 month ago

Currently there are two BIDS validator "builds":

  1. the "legacy" validator, implemented mainly with custom Java Script
  2. the "schema" validator, based on the BIDS schema

We use the legacy validator, but the schema validator will sooner (!) or later replace the legacy validator.

The schema validator will also be more accurate in covering the BIDS specification and might raise errors where the currently used legacy validator remained silent.

We should prepare for a switch, and the potential fixes at mne-bids that this may involve ... or at least be aware of it.

sappelhoff commented 1 month ago

See for example:

hoechenberger commented 1 month ago

+1 on switching sooner than later

sappelhoff commented 1 week ago

I think the right way would be to add an additional CI run to our suite that uses the schema validator, and then to try and make these tests pass bit by bit.

See also: https://github.com/bids-standard/bids-examples/blob/7c18d6840982518a0251cfeb59fe5c4610099ea1/.github/workflows/validate_datasets.yml#L69-L75