mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
131 stars 85 forks source link

If anonymize=True in "write..." and Brainvision --> DO NOT convert to BrainVision #473

Closed sappelhoff closed 4 years ago

sappelhoff commented 4 years ago

Currently, all EEG files are converted to BrainVision format if anonymize is set in write_raw_bids.

for data that is already in BrainVision format, this means that it's unnecessarily re-written using pybv.

A cleaner (IMO more sensible and less error prone) alternative would be to write a short snippet of code in MNE-BIDS that ...

agramfort commented 4 years ago

this makes then BV a special case. For me it's more to be used as a unit-test.

my 2c

sappelhoff commented 4 years ago

together with #469 we'd have "two special cases" --> I just say that if we can achieve anonymization with a few lines of code WITHOUT having to change the original data format ... then that's better than data format conversion.

agramfort commented 4 years ago

fair enough