search

mne-tools / mne-bids

MNE-BIDS is a Python package that allows you to read and write BIDS-compatible datasets with the help of MNE-Python.
https://mne.tools/mne-bids/
BSD 3-Clause "New" or "Revised" License
133 stars 88 forks source link

tests for iEEG #79

Closed jasmainak closed 5 years ago

jasmainak commented 6 years ago

Currently the iEEG conversion is not at all tested.

cc @choldgraf

jasmainak commented 6 years ago

@choldgraf do you have any suggestion what data we should use for the testing here?

choldgraf commented 6 years ago

Whenever the iEEG spec gets merged there should be some sample datasets released as well, we could just use those (they're lightweight because they don't have the actual data). Or we could just define our own dataset

jasmainak commented 6 years ago

we do need actual data because mne-bids needs header information to write the json files. But on further thought, for the tests, we could probably make do with doing raw.set_channel_types and changing it to ecog. @monkeyman192 or @sappelhoff does any of you have time to take a stab at this?

sappelhoff commented 6 years ago

I can give it a shot, but we will definitely need a full pass of mne-bids (preferably by @choldgraf) to integrate iEEG properly.

Note that iEEG will probably also support the NWB and MEF3 file formats, which are not yet implemented in MNE-Python. So we won't be able to cover these for now.

jasmainak commented 6 years ago

iEEG is already implemented. So, it would be good to add just the tests (and any small related fixes). I would ideally not want to have it conflict too much with #99 and #106 . Thanks a lot for taking a shot at it !

jasmainak commented 6 years ago

I agree we'll need a PR which does a full-pass down the line, but I would say it's not a blocker for our release at the moment. If we have the tests, I'm happy for now :)