search

mne-tools / mne-binder

Integration with mybinder.org
BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Relation between MNE-binder and MNE-docker #9

Open rob-luke opened 3 years ago

rob-luke commented 3 years ago

I would like to clarify the relationship between this repository and MNE-binder, and propose that this repository be refactored to rely on MNE-binder or be depreceated.

Currently both MNE-binder and MNE-docker contain Dockerfiles to run MNE-python via docker. This seems to be a dupliation of work. Instead I propose we do either:

  1. Keep both MNE-binder and MNE-docker. Release an image of MNE-docker (see https://github.com/mne-tools/mne-docker/pull/9), and build MNE-binder from that image.
    • Reduces duplicate code.
    • But this repo is then only adding the link to the notebooks.
    • Easier to find for people looking for binder (could be overcome by rewriting the MNE-docker readme).
  2. Depreceate MNE-binder. Use MNE-docker to build a binder image.
    • This will just add a single file to MNE-docker that links to the MNE notebooks

My vote is for 2. Any opinions/thoughts @agramfort @larsoner @wmvanvliet @bloyl ?

wmvanvliet commented 3 years ago

I'm fine with depricating mne-binder in favor of mne-docker