search

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
68 stars 34 forks source link

Recreate repo with template #1

Closed adam2392 closed 3 years ago

adam2392 commented 3 years ago

Hi @larsoner I just realized there is a men-python template repository. Any chance you can delete this one and I can go ahead and recreate the repo?

larsoner commented 3 years ago

I'm not sure how up to date that is, it might be better to just grab what you need from mne-nirs or mne-bids, both of which are a good combination of kept-up-to-date and also close to what MNE-Python does. Actually looking at it I would say MNE-Realtime has the closest structure (testing Windows on Azure, Linux/macOS on GH Actions, and building docs with CircleCI). So I would just copy some of those files over, edit them, start pushing commits, and iterate until you get all green CIs on pytest mne_connectivity, and to start I would make a mne_connectivity/tests/* a literal copy-paste from mne/connectivity/tests/*.

That way you get all of the testing and CI infrastructure working first. Next I would port mne.connectivity code into the mne_connectivity namespace however you're planning to do it, and replace mne.connectivity.* in the tests with mne_connectivity.* as you port things over.

WDYT?

adam2392 commented 3 years ago

Okay sounds good! I will just use the mne-realtime template then. I'll get all this started in one PR to handle the "official refactoring step then".