search

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
66 stars 34 forks source link

MAINT: Update for 1.2 and bump version #107

Closed larsoner closed 1 year ago

larsoner commented 1 year ago

@adam2392 we need to remove _get_args to comply with 1.2's removal of it. @adam2392 could you merge this if happy and cut a 0.4.0 release?

cc @drammock this one needed an update due to _get_args

adam2392 commented 1 year ago

Should we wait on the GSoC PR? Or still too much WIP?

larsoner commented 1 year ago

If you're not totally confident it's usually better to cut a release then merge a big change

larsoner commented 1 year ago

@adam2392 all green here. You up for merging and cutting a release?

adam2392 commented 1 year ago

I'll try to do a release later today!

larsoner commented 1 year ago

@adam2392 just a friendly reminder to cut a release when you get a chance

adam2392 commented 1 year ago

Done!

adam2392 commented 1 year ago

Thanks!