mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
66 stars 34 forks source link

[ENH] Added n_con arg to function call #133

Closed Avoide closed 1 year ago

Avoide commented 1 year ago

PR Description

Moved the hard-coded variable n_con to be one of the arguments for the function call. To enable choosing the number of connections shown, instead of always 20. Added a default option, to make it compatible with previous usage.

Merge checklist

Maintainer, please confirm the following before merging:

Avoide commented 1 year ago

I fixed the style errors associated with the file I changed, but the test is not passing due to errors in two other files: envelope.py and smooth.py. I already corrected those codespell errors in my other PR, but does it make sense to also correct in this PR?

adam2392 commented 1 year ago

I already corrected those codespell errors in my other PR, but does it make sense to also correct in this PR?

Now that I've merged in the other PR, you can "rebase your changes on top of main", or "merge in main". Lmk if you don't know how to do that.

Can you also add a changelog entry to doc/whats_new.rst? You can see the previous releases file for a format of how to do so.

adam2392 commented 1 year ago

Oh actually, I forgot I can just merge in main from the PR itself here with a button click, so now you can just run git pull to get the latest changes on your branch

Avoide commented 1 year ago

Thanks, I updated whats_net and added an entry into authors. Hopefully the link should work.

adam2392 commented 1 year ago

Thanks @Avoide !