search

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
68 stars 34 forks source link

Fix failing unit tests #172

Closed tsbinns closed 8 months ago

tsbinns commented 8 months ago

Codestyle checks are failing due to benchmarks/bench_var.py and benchmarks/single_epoch_conn.py not being properly formatted. See e.g. #163, #171 for failing checks.

Have now run black on these files to hopefully fix things.

larsoner commented 8 months ago

I think you're also hitting the pytest 8 warning catching change. For now can you try pinning to pytest<8? It should fix CIs

tsbinns commented 8 months ago

Thanks for the suggestion @larsoner! That solved everything but the failing windows 3.11 unit tests:

ERROR: To modify pip, please run the following command:
C:\hostedtoolcache\windows\Python\3.11.7\x64\python.exe -m pip install --upgrade pip setuptools wheel

Have to admit I don't fully understand the difference between this suggestion and what is already being performed in workflows/unit_tests.yml:

pip install --upgrade pip setuptools wheel
tsbinns commented 8 months ago

@larsoner Out of curiosity, do you have an idea what might have caused the windows check to suddenly start failing, and why this didn't affect the macos or ubuntu checks?

larsoner commented 8 months ago

GitHub actions updates parts of their runner images from time to time. I'm guessing some recent update changed some file permissions. Windows has this weird thing where you have to do python -m pip ... rather than pip ... to get the right permissions to uninstall the old pip version sometimes, must have been one of those times!