search

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
68 stars 34 forks source link

[WIP] Setup of initial refactoring mne.connectivity + examples + docs + CI #2

Closed adam2392 closed 3 years ago

adam2392 commented 3 years ago

Closes #1

Britta's GH handle is popping up, @larsoner do you mind tagging her?

TODO:

larsoner commented 3 years ago

That would be @britta-wstnr

larsoner commented 3 years ago

Azure is useful for windows but can always be added later. For now I would stick to CircleCI + GH Actions

larsoner commented 3 years ago

@adam2392 have you looked at the failures? You can look at the logs to try to figure out the problem. For example, you don't have tools/ so for example you can do what mne-realtime does:

https://github.com/mne-tools/mne-realtime/blob/de6dddb0ae63012c69c55e66d873ae41e5f6df9a/.github/workflows/linux.yml#L23-L26

Though if you did a direct copy-paste I'm not sure why you'd have this problem...

adam2392 commented 3 years ago

Yeah I think I did a copy-paste and have now modified a few things, but looking through the CI there's a bunch more things that mne-realtime installs. I was thinking of using the mne-bids version instead. Pushing up a version now.

Re Unit tests: Everything passes locally and nothing needs to change.

Re some distribution: I'm having some issues building the docs locally possibly because of some complexities in conf.py that I'm just not fully understanding. Considering using mne-bids there for that too since that has given me some good success when I used it as a template for mne-hfo.

Current Status of Refactoring

So I just updated the CI mainly for GH actions (circleCI and codecov isn't activated until a master branch is up-to-date). I think it's mostly correct. Might need a few iterations there. The other thing I just fixed was the style via make pep, and pytest via pytest mne_connectivity.

adam2392 commented 3 years ago

Having a bit of trouble getting GH actions for the style/build to work. I'm basically copying stuff from mne-realtime and mne-bids. I'm not sure if there is some sort of weird syntax errors I'm doing, so trying to read through and match repo by repo.