search

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
66 stars 34 forks source link

[ENH] Add epoch/time resolved spectral connectivity ported from Frites #67

Closed adam2392 closed 2 years ago

adam2392 commented 2 years ago

PR Description

Closes: #63

TODO:

  1. Add more sufficient unit tests
  2. Add error checking within function

Merge checklist

Maintainer, please confirm the following before merging:

adam2392 commented 2 years ago

@EtienneCmb and @ViniciusLima94 , I've ported over your implementation for connectivity-over-time. I did some refactoring to make sure the implementation had some mne-connectivity-API style, but mostly didn't change much.

It is called spectral_connectivity_epochs. I will need to overhaul some naming before making a v0.3 release. I also added unit/regression tests for this function.

After this gets merged, I can then help make a few PRs to frites to wrap this function + add mne-connectivity dev version to your CI builds.

I'm thinking by v0.4/0.5, I might also do a JOSS paper, and I invite you both to be co-authors on it since you're assisting in the shared connectivity implementations.

How does this all sound?

EtienneCmb commented 2 years ago

Hi @adam2392, and happy new year,

Everything sounds great ! Sure, we can then discuss about the integration of mne-conn inside frites. For the JOSS paper, Vinicius and I we can also help in writing the paper if you need. Thank you for including us :)

Best,

adam2392 commented 2 years ago

Hi @adam2392, and happy new year,

Everything sounds great ! Sure, we can then discuss about the integration of mne-conn inside frites. For the JOSS paper, Vinicius and I we can also help in writing the paper if you need. Thank you for including us :)

Best,

Thanks! happy New Years to you both as well :)