[ENH, MRG] remove duplicated code, add deprecation for subplot indexing [skip ci

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.

https://mne.tools/mne-connectivity/dev/index.html

BSD 3-Clause "New" or "Revised" License

66 stars 34 forks source link

[ENH, MRG] remove duplicated code, add deprecation for subplot indexing [skip ci #88

Closed alexrockhill closed 2 years ago

alexrockhill commented 2 years ago

This brings mne-connectivity up to date with changes to connectivity plotting and prevents getting out of sync in the future. Adds a few features from https://github.com/mne-tools/mne-python/pull/10439.

Merge checklist

Maintainer, please confirm the following before merging:

[ ] All comments resolved
[ ] This is not your own PR
[ ] All CIs are happy
[x] PR title starts with [MRG]
[x] whats_new.rst is updated
[ ] PR description includes phrase "closes <#issue-number>"

alexrockhill commented 2 years ago

Not sure what's going on with Circle, it looks like some kind of permissions error but otherwise this should be good

cc @adam2392

alexrockhill commented 2 years ago

Since Circle isn't running, I just ran the examples locally and got some deprecation warnings so I fixed those too

alexrockhill commented 2 years ago

Yep, I fixed the workflow issue. I just fixed some overlapping text as well, but that's all I wanted to change

alexrockhill commented 2 years ago

It looks good on the previous ones but probably wait until circle finishes https://497-369628653-gh.circle-artifacts.com/0/dev/auto_examples/mne_inverse_label_connectivity.html

adam2392 commented 2 years ago

Thanks @alexrockhill !

alexrockhill commented 2 years ago

Oops, one last thing there was a code-block that got messed up.