mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
68 stars 34 forks source link

Update time.py due to error in spectral_connectivity_time #98

Closed SezanMert closed 2 years ago

SezanMert commented 2 years ago

PR Description

It is the prospective solution of #95

It fixes the incompatibility of dimensions of frequencies in the creation of EpochSpectroTemporalConnectivity object on line 223 by providing the frequencies of interest into the object, rather than the frequencies used in the time-frequency decomposition.

Merge Checklist

Maintainer, please confirm the following before merging:

adam2392 commented 2 years ago

Thanks for the PR and spotting this issue @SezanMert ! Can you add a changelog entry to the what's_new.rst file inside docs/ folder?

And are you up to write a short unit-test that broke on the old version before this change, but works now?

drammock commented 2 years ago

@adam2392 FYI the AZP failure here is a GitHub problem relating to the testing-data repo.

adam2392 commented 2 years ago

@adam2392 FYI the AZP failure here is a GitHub problem relating to the testing-data repo.

I'm going to just merge as is then for now...

adam2392 commented 2 years ago

Thanks @SezanMert for the in depth issue and easy fix!