search

mne-tools / mne-connectivity

Connectivity algorithms that leverage the MNE-Python API.
https://mne.tools/mne-connectivity/dev/index.html
BSD 3-Clause "New" or "Revised" License
68 stars 34 forks source link

Gathering feedback on API Proposal for state-space model #99

Open jadrew43 opened 2 years ago

jadrew43 commented 2 years ago

As part of the Google Summer of Code program, I am constructing an API proposal to implement a state-space model using a Kalman Filter and an Expectation Maximization algorithm to estimate functional connectivity between regions of interest as recorded in M/EEG. The proposal also outlines the implementation of methods to compute the statistical significance between functionally connected networks.

This is my first API proposal so any feedback from variables to proposal structure is sincerely appreciated!

References:

adam2392 commented 2 years ago

Great start! Left a few questions/comments.

If I misunderstood anything tho lmk.

larsoner commented 2 years ago

Left a comment with my naive idea for a simpler API. My major suggestion is that we move to iterating via a WIP PR to this repo with a new examples/plot_meglds.py or so that someday will operate on sample data so that we can see the API in action, and pick the best starting (simple) API as possible