search

mne-tools / mne-cpp

MNE-CPP: A Framework for Electrophysiology
https://mne-cpp.org/
BSD 3-Clause "New" or "Revised" License
150 stars 137 forks source link

reserved identifier violation #856

Open elfring opened 2 years ago

elfring commented 2 years ago

I would like to point out that identifiers like “_Tp” and “_MatrixType” do eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

LorenzE commented 2 years ago

Are these Eigen library naming?

elfring commented 2 years ago

:thought_balloon: I suggest to avoid that such software components depend on undefined behaviour.

juangpc commented 2 years ago

Is it us, not making a good use of Eigen, or is Eigen somehow not following 100% the standard?

elfring commented 2 years ago

:thought_balloon: Would you like to distinguish remaining open issues better for the involved software libraries?

juangpc commented 2 years ago

Yes.

elfring commented 2 years ago

:thought_balloon: How will the chances evolve to delete misplaced underscores from affected identifiers?

juangpc commented 2 years ago

This change will probably work. Would you want to try a pr with the change?

Juan

On Mon, Nov 1, 2021 at 11:58 AM Markus Elfring @.***> wrote:

💭 How will the chances evolve to delete misplaced underscores from affected identifiers https://en.cppreference.com/w/cpp/language/identifiers#In_declarations?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mne-tools/mne-cpp/issues/856#issuecomment-956356858, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEKMIE6IGKMRG723I73ISDUJ22JDANCNFSM5HBB2G2A .