search

mne-tools / mne-cpp

MNE-CPP: A Framework for Electrophysiology
https://mne-cpp.org/
BSD 3-Clause "New" or "Revised" License
151 stars 137 forks source link

Add ui files to CMakeLists so IDEs can show them #926

Closed gabrielbmotta closed 1 year ago

gabrielbmotta commented 1 year ago

Add ui files to CMakeLists.txt in mnescan plugins and disp library so that IDEs (like QtCreator) will show them in the project view.

juangpc commented 1 year ago

in mne_analyze/mne_analyze/resources/images/appIcons/mne_analyze.iconset/ is there an empty CMakeLists.txt file?

juangpc commented 1 year ago

Just pushed some minor edits, styling, space characters finishing lines, long lines, things of that nature.

juangpc commented 1 year ago

Whenever this is ready, or needs review again, do let me know

gabrielbmotta commented 1 year ago

Just pushed some minor edits, styling, space characters finishing lines, long lines, things of that nature.

As much as I agree with some of the styling changes made, why are they being pushed to this PR? They are on completely separate files and concern different lines of the CMakeLists.txt, and do not affect ui files. And on top of that one of the changes to multiline commands broke the build because it was previously commented out and the new line added did not have a comment.

juangpc commented 1 year ago

Just pushed some minor edits, styling, space characters finishing lines, long lines, things of that nature.

As much as I agree with some of the styling changes made, why are they being pushed to this PR? They are on completely separate files and concern different lines of the CMakeLists.txt, and do not affect ui files. And on top of that one of the changes to multiline commands broke the build because it was previously commented out and the new line added did not have a comment.

Sorry about that. let me get back in a min

juangpc commented 1 year ago

Ready on my side.