search

mne-tools / mne-cpp

MNE-CPP: A Framework for Electrophysiology
https://mne-cpp.org/
BSD 3-Clause "New" or "Revised" License
154 stars 141 forks source link

[ENH] Use resources folder for sample data #927

Closed juangpc closed 1 year ago

juangpc commented 1 year ago

@gabrielbmotta Wondering... Shouldn't it be out/Release.... so on? https://github.com/mne-tools/mne-cpp/blob/8cb8beed8560fc9f227ffdc1b5fb7053270fb854/.github/workflows/release.yml#L570

juangpc commented 1 year ago

Here in Test the Build (https://github.com/mne-tools/mne-cpp/blob/main/doc/gh-pages/pages/development/buildguide_cmake.md#test-the-build) I would prefer to organize all references to sample data in one place only. What do you think?

gabrielbmotta commented 1 year ago

@gabrielbmotta Wondering... Shouldn't it be out/Release.... so on?

https://github.com/mne-tools/mne-cpp/blob/8cb8beed8560fc9f227ffdc1b5fb7053270fb854/.github/workflows/release.yml#L570

Yes. This also goes into a larger issue of the wasm build with cmake which still needs debugging.

gabrielbmotta commented 1 year ago

Here in Test the Build (https://github.com/mne-tools/mne-cpp/blob/main/doc/gh-pages/pages/development/buildguide_cmake.md#test-the-build) I would prefer to organize all references to sample data in one place only. What do you think?

Sure, what do you have in mind?

juangpc commented 1 year ago

so that I don't forget, let me post this here: todo, references to bin/ folder here https://github.com/mne-tools/mne-cpp/blob/main/doc/gh-pages/pages/documentation/scan_prerecordeddata.md

juangpc commented 1 year ago

so that I don't forget, let me post this here: todo, references to bin/ folder here https://github.com/mne-tools/mne-cpp/blob/main/doc/gh-pages/pages/documentation/scan_prerecordeddata.md

done

juangpc commented 1 year ago

Any build of any type links to the same folder through a full path sym link. You can move the out/Whatever folder around and everything should still work. You can actually copy the data to the data folder in out/Whatever and you have a release you can deploy within that same platform. Besides whatever bug cmake wants to throw at me, I think it is a reasonable solution this way. @gabrielbmotta what do you think?

juangpc commented 1 year ago

Not sure what are ifw_installer, convention and wizards doing. How often they are used, etc... I've moved them to resources because they are not code or tooling scripts.

juangpc commented 1 year ago

dropping this