mne-tools / mne-cpp

MNE-CPP: A Framework for Electrophysiology
https://mne-cpp.org/
BSD 3-Clause "New" or "Revised" License
152 stars 139 forks source link

[FIX] build script return val #937

Closed gabrielbmotta closed 1 year ago

gabrielbmotta commented 1 year ago

Fix build flag passed with --D. Should be -D. Have build script return exit with error if build fails.

Currently our script returns success (0), regardless of the success of the build. This leads to the unfortunate circumstance of ant GH Action step running this script to pass, regardless of whether the build itself was successful. Typically this did not make itself apparent, since there are subsequent steps that would fail in the absence of a build. PR #935 had failing static builds on mac and linux, but since there are no subsequent steps, the build passed. PR #936 addresses the static flag issue.