mne-tools / mne-cpp

MNE-CPP: A Framework for Electrophysiology
https://mne-cpp.org/
BSD 3-Clause "New" or "Revised" License
151 stars 137 forks source link

WIP [ENH,MAINT] More build options #950

Closed gabrielbmotta closed 1 year ago

gabrielbmotta commented 1 year ago

Add the following options to the build project script:

Change cmake build flags to positive statements rather than double negatives (instead of setting DO_NOT_BUILD_X to OFF we now set BUILD_X to ON)

juangpc commented 1 year ago

Thoughts/ideas on Specifics: "clean-all" vs "rm -fr build out" . Qt version opt vs "-- -DQtDir=... " "chill" vs "parallel=false" (true by default)...

We're reaching a point where the number of options is becoming almost too broad. But I guess you probably agree on this, so you're adding all these options because... (my guess is that) it allows to interface always with the build script in the ci? Once we reach a point where all the ci workflows and our typical workflow already are able to use this build script, I think it is a good point to stop and do not add more options. After all there is this extra args thing after "--" which allows to directly interface with any option cmake might use.