Closed guiweber closed 5 years ago
Thank you @guiweber for your feedback.
Clearly, the doc of univariate.compute_spect_edge_freq
can be improved (as per your suggestions). I'll fix that.
@guiweber #52 should fix it. If it does not completely address your concerns, do not hesitate to comment on the PR.
Thanks!
The description for the optional
edge
parameter ofunivariate.compute_spect_edge_freq
is as follow:There are two issues that makes the actual behavior unexpected when compared to the documentation:
The sentence If None, edge = [0.5] is used implies that passing
edge = [0.5]
to the function should give the same results as calling the function without the parameter. It is however not the case. To get the same results,edge = [50]
must be passed to the function.If
edge is not None
, its values are not actually "normalized" as the documentation says, but are simply divided by 100 as shown in the code belowI suggest fixing either by removing the explanation about normalization, removing the division and let the user enter a value between 0 and 1, or by making the current behavior clearer in the documentation. A better explanation of the current behavior could be as follow: