search

mne-tools / mne-gsoc2018-3d

Sandbox for GSoC 2018 3D Viz
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Fixes #16, Inversion of the instensity. #18

Closed OlehKSS closed 6 years ago

OlehKSS commented 6 years ago

I have inverted values of morphometric data, but it seams that in PySurfer morphometric data pre-processing pipeline more complex. I don't understand what lies behind PySurfer's approach. Should I keep morphometry processing as it is or should it be changed?

agramfort commented 6 years ago

you should mimic what PySurfer does so figures look as similar as possible.

choldgraf commented 6 years ago

@OlehKSS could you post an image of what the brain looks like in pysurfer vs. this PR so we can compare?

OlehKSS commented 6 years ago

Hello, sorry for the delay. I had problems with mayavi, some problems with dependencies. Moreover PySurfer doesn't work well on my Virtual Machine, it seems to be quite hungry for hardware resources. This is what I obtain with PySurfer

mesh_surfer-intens

This is what @larsoner obtains with PySurfer

mesh_surfer-intens

This what I get with mne_g3d mesh_current-intens

agramfort commented 6 years ago

color do not match and it's hard to see without the inflated surfaces. But it looks like a nice brain though :)

larsoner commented 6 years ago

This is what I get over on https://github.com/OlehKSS/mne-gsoc2018-3d/pull/2 (inflated)

screen shot 2018-05-30 at 21 49 58
agramfort commented 6 years ago

a bit dark color for the brain but pretty nice !

larsoner commented 6 years ago

It is prossibly a difference in lighting now that I think about it

OlehKSS commented 6 years ago

So, is it good as it is? Ipyvolume has no controls over lighting for now, it can be solved later.

agramfort commented 6 years ago

yes